Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add optional comments to automated checks in assessment. #4741

Closed
ssawczyn opened this issue Sep 29, 2021 · 5 comments
Closed

Ability to add optional comments to automated checks in assessment. #4741

ssawczyn opened this issue Sep 29, 2021 · 5 comments
Assignees

Comments

@ssawczyn
Copy link

Is your feature request related to a problem? Please describe.

When performing an assessment, it would sometimes be handy to be able to add additional comments for context or other reasons. For example, I recently marked a bunch of links as failed for link purpose and it would have been great to optionally have the ability to add comments for each failure in order to provide alternative (more descriptive) link text, or additional context about why I failed it. I'm envisioning this working similarly to how I can manually add an issue to non-automated tests, e.g. an add button or comment field could be present for each failed instance.

Describe the desired outcome

I'd like to be able to add optional comments to failed automated checks in order to provide additional guidance or context. Ideally, this could be an additional column in the instances table, or an add button could be placed in the table which triggers a dialog similar to adding an issue in non-automated checks.

Describe alternatives you've considered

The only alternative I can think of is to copy the exported final report into some other template and then add my comments, but this is a real pain, not to mention very messy.

@ghost ghost added the status: new This issue is new and requires triage by DRI. label Sep 29, 2021
@madalynrose madalynrose added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Sep 29, 2021
@ghost ghost assigned ferBonnin Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ferBonnin
Copy link
Contributor

Hi @ssawczyn thanks for your feature request! this looks like a duplicate of #485. Could you please take a look and let us know if that feature request covers this one?

@ferBonnin ferBonnin added the status: needs author feedback This issue requires additional information from the issue author. label Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Sep 29, 2021
@ssawczyn
Copy link
Author

@ferBonnin yes, unfortunately, this is a duplicate, my apologies -- I somehow missed the other.

@ghost ghost added status: needs attention The author has provided additional feedback and now requires attention. and removed status: needs author feedback This issue requires additional information from the issue author. labels Sep 29, 2021
@ferBonnin
Copy link
Contributor

@ferBonnin yes, unfortunately, this is a duplicate, my apologies -- I somehow missed the other.

No worries, thanks for the request @ssawczyn! Please feel free to upvote #485 if you'd like 🙂

@ferBonnin ferBonnin removed the status: needs attention The author has provided additional feedback and now requires attention. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants