Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: PublishSymbols default SearchPattern (and doc) is a poor choice leading to not being able to analyze crashes and other reliability issues #19691

Closed
4 of 7 tasks
ivberg opened this issue Mar 26, 2024 · 1 comment

Comments

@ivberg
Copy link

ivberg commented Mar 26, 2024

New issue checklist

Task name

PublishSymbolsV2

Task version

2.234.1

Issue Description

SearchPattern in PublishSymbols@2 has a bad default that will result in not able to properly analyze Reliability issues including crashes, hangs, memory leaks, etc. Since the ability to analyze is the MAIN purpose of publishing symbols, this is clearly a bad default.

I even worked in the crashdump analysis area for Microsoft, and did not realize right away these were poor defaults, until I was not able to analyze crash dumps for my own process.

Backstory: Almost all modern binaries x64, arm64, .NET REQUIRE binaries (.exe, .dll) to also be uploaded to the symbol server along with .pdbs files. Without these files, stack unwinding cannot happen and analysis will be messed up in WinDbg, VS, or other analysis tools.

SearchPattern - Search pattern
string. Required. Default value: /bin//*.pdb <--- Bad default

Specifies the pattern used to discover the PDB files to publish. See File matching patterns reference for more information.

The task defaults for PublishSymbols and docs should change to this which properly publish symbols for all 3 file types.

            SearchPattern: |
              **/bin/**/*.pdb
              **/bin/**/*.exe
              **/bin/**/*.dll

Also, this SearchPattern syntax is not intuitive if you read the file matching pattern docs. I got it wrong the first time resulting in no files published

Related doc issue: https://github.com/MicrosoftDocs/azure-devops-yaml-schema/issues/330

Environment type (Please select at least one enviroment where you face this issue)

  • Self-Hosted
  • Microsoft Hosted
  • VMSS Pool
  • Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

No response

Operation system

Windows 11

Relevant log output

N/A

Full task logs with system.debug enabled

No response

Repro steps

No response

Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants