Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Snapshots: Display Pressed Keys for keyboard.press Actions #34093

Open
midleman opened this issue Dec 19, 2024 · 0 comments
Open

[Feature]: Snapshots: Display Pressed Keys for keyboard.press Actions #34093

midleman opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels

Comments

@midleman
Copy link

midleman commented Dec 19, 2024

🚀 Feature Request

Add more context to the keyboard.press action in the snapshots view by displaying the specific button being pressed in orange text (similar to how other snapshot actions are displayed).
Image

Example

Currently, when reviewing traces in the snapshots view, users need to inspect the Call section to determine what button was pressed during a keyboard.press action. With this feature, the specific button (e.g., “Enter,” “Tab,” “Ctrl+P”) would be shown directly in the snapshot step, in orange text, similar to how other snapshot actions are displayed.

For instance:

  • Before: The snapshot step shows keyboard.press without additional context.
  • After: The snapshot step shows keyboard.press (Enter) or keyboard.press (Tab) directly in the list of steps.

Motivation

This feature improves trace readability and efficiency, especially for traces with numerous keystrokes. Currently, users need to dig into the Call section to identify the specific button being pressed, which interrupts the debugging flow and can be cumbersome for complex traces. By displaying the button context in the snapshot step, users can more quickly and easily understand the sequence of actions, leading to a smoother debugging experience.

This addition aligns with the existing design pattern of exposing contextual information for other actions in orange text, making the snapshots view more consistent and intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants