Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTEST0017 (Assertion arguments should be passed in the correct order) shouldn't warn if both arguments are literals #4299

Open
Youssef1313 opened this issue Dec 10, 2024 · 1 comment · May be fixed by #4460

Comments

@Youssef1313
Copy link
Member

Describe the bug

If both arguments are literals, e.g:

Assert.AreEqual(0, 1);

we currently issue a warning, but following the codefix will still keep the warning.

We shouldn't issue a diagnostic when "both" arguments look like they should be "expected".

Currently, the above snippet will already produce MSTEST0025 (Use 'Assert.Fail' instead of an always-failing 'Assert.AreEqual' assert).

@Evangelink
Copy link
Member

I agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants