Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python extension extra data list full extension identifier #23126

Closed
jrieken opened this issue Mar 25, 2024 · 7 comments · Fixed by #24570
Closed

Python extension extra data list full extension identifier #23126

jrieken opened this issue Mar 25, 2024 · 7 comments · Fixed by #24570
Assignees
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

Testing microsoft/vscode#208468

  • from QP select "issue python"
  • show additional extension info
  • it includes the full identifiers of all installed extensions (that information is something VS Code itself shortens)
@justschen
Copy link

cc. @paulacamargo25 on this since she implemented it 👍

@luabud
Copy link
Member

luabud commented Mar 25, 2024

just to confirm I understand it correctly, is the suggestion is to change the table in the Python's "Installed Extensions" markdown table under "Include additional extension info" to follow the same format as the VS Code's "include my enabled extensions" table?
image

VS Code's:
image

@luabud luabud transferred this issue from microsoft/vscode Mar 25, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 25, 2024
@justschen
Copy link

@jrieken @luabud revisiting this after I thought about it for a little bit:

the reason @paulacamargo25 adds the extensions here is because when filing on an extension, the reporter doesn't have a checkbox/option for sending enabled extensions, only when the source is vs code or don't know will enabled extensions be sent.

this could be up to further discussion though (if you're filing on an extension, to that extension's github, do they need to have a default check box for including enabled extensions?)

@karthiknadig
Copy link
Member

@justschen For Python extension, and our suite of extensions this information is often useful. There are cases where some combination of 3rd party extensions with python extensions has issues. This is useful to catch those quickly.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Dec 8, 2024
@karthiknadig karthiknadig removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Dec 9, 2024
@karthiknadig
Copy link
Member

if you're filing on an extension, to that extension's github, do they need to have a default check box for including enabled extensions?

Yes. See my previous comment.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@jrieken
Copy link
Member Author

jrieken commented Dec 10, 2024

Re-open, this isn't about listing extensions but about listing them with the fully qualified identifier. Python should use the same "obfuscation" that vscode uses

@jrieken jrieken reopened this Dec 10, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 10, 2024
@karthiknadig
Copy link
Member

@jrieken Ah! I see thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants