Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Hot-reload for CLI #423

Open
2 tasks
samad-yar-khan opened this issue Jun 7, 2024 · 7 comments
Open
2 tasks

Enable Hot-reload for CLI #423

samad-yar-khan opened this issue Jun 7, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@samad-yar-khan
Copy link
Contributor

Why do we need this ?

  • The current dev experience for the main app is made super convenient using ./dev.sh which triggers the CLI to manage the Docker containers
  • The dev experience for the CLI itself is not convenient as simple changes to the CLI require a reload.

Acceptance Criteria

  • Enable Hot reloading on the CLI
  • Make sure the hot reload to the CLI itself does not take too long and does not build the containers again from scratch

Further Comments / References

@samad-yar-khan samad-yar-khan added the enhancement New feature or request label Jun 7, 2024
@VipinDevelops
Copy link
Contributor

VipinDevelops commented Aug 8, 2024

Hey @samad-yar-khan Can you explain this issue in more detail

Currently we build and start the CLI its like starting point of the development server that handles everything and we have dev script in the CLI if someone want to run that in watch mode with hot reload.

so Can you please explain what are we trying to achieve here ?

@jayantbh
Copy link
Contributor

@VipinDevelops this issue basically meant that when you're working on a change in the CLI itself, instead of shutting down and restarting all changes, it should have a live-reload functionality similar to how you'd have experienced in the usual UI dev.

@VipinDevelops
Copy link
Contributor

VipinDevelops commented Aug 14, 2024

Hey @jayantbh Thanks for explaining, but we already have a dev scripting in the CLI that can run it with hot reload.

Here is the Dev Script which run CLI with Watch Mode.

@jayantbh
Copy link
Contributor

@VipinDevelops does it actually work like live-reload for you? Because it seems to basically trigger a whole-app-reload for the CLI for me on changes.

@VipinDevelops
Copy link
Contributor

So @jayantbh correct me if I am wrong we want to make a feature that lets use inject updated source code into a running app without a restart

@jayantbh
Copy link
Contributor

Correct. The running app here is the CLI app. Not the frontend or backend code.

@VipinDevelops
Copy link
Contributor

VipinDevelops commented Aug 14, 2024

Got it and that code with run other services thanks for explaining I will try to explore potential solutions for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants