Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable PR level filtering for better Change Failure Rate reporting #557

Open
jayantbh opened this issue Oct 1, 2024 · 1 comment
Labels
advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! enhancement New feature or request help wanted Extra attention is needed

Comments

@jayantbh
Copy link
Contributor

jayantbh commented Oct 1, 2024

Why do we need this ?

Currently CFR is based on reverted PRs.
While it's a bit of a challenge to associate it with much else based purely on PRs, perhaps some filtering/calculating can be done based on PR titles, branches, labels, etc.

For example, maybe I could include in any PRs that start like "Fix #1234 ABCD" to mean that it's a fix for PR 1234, so the "failure" could be associated with that PR, and the resultant resolution time could be calculated as the time between PR 1234 being merged, and "Fix #1234 ABCD" being merged.

Thoughts?

@jayantbh jayantbh added enhancement New feature or request help wanted Extra attention is needed hacktoberfest advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! labels Oct 1, 2024
@aadarsh-nagrath
Copy link

This makes a lot of sense for improving the accuracy of DORA metrics in Middleware. Since CFR is based solely on reverted PRs, it misses out on a significant number of failures or issues that might not result in an actual PR revert but still require resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants