Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HTTP/2 based server for the webserver #598

Open
jayantbh opened this issue Oct 16, 2024 · 11 comments
Open

Switch to HTTP/2 based server for the webserver #598

jayantbh opened this issue Oct 16, 2024 · 11 comments
Assignees
Labels
dev experience enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed web-server Issue related to web-server

Comments

@jayantbh
Copy link
Contributor

Why do we need this ?

HTTP/2 has some notable performance improvements over HTTP/1 (or 1.1), such as multiplexing, that should result in notably faster load speeds and better perceived performance of the web app.

https://www.cloudflare.com/en-gb/learning/performance/http2-vs-http1.1/

Next.js needs a bit wrangling around with it to make it work with HTTP/2 servers.
vercel/next.js#10842

@jayantbh jayantbh added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed web-server Issue related to web-server dev experience hacktoberfest labels Oct 16, 2024
@not-meet
Copy link

I would like to work on this.. plz assign this issue to me . :-)

@jayantbh
Copy link
Contributor Author

Sure. Go ahead. :)

@sikehish
Copy link

I would love to work on this, would like to be assigned if the other assignee fails to accomplish it.

@not-meet
Copy link

@sikehish you can try it buddy...i somewhat was not able to achieve the desired outcome... though if you reach the output i would love to learn from your pr..:-)

@not-meet
Copy link

hi @jayantbh i tried to solve the issue again and somewhat was able to figure it out...there are two ways to solve the issue one is using node modules and on is with the help of NGINX... i somewhat was able to do the task with the help of node.... but it requires public and private open ssl keys on the local machine...should i opt for this method... :-)

@jayantbh
Copy link
Contributor Author

Sure. IIRC Http2 will require SSL even with the nginx method because it works only on SSL.

Generating certificates is easy but the process of generating and serving certificates should happen when the Dev server or production image are started, and must not be committed to the repo.

Especially in production mode, there should be a mechanism to automatically renew the certificate every month or two.

@not-meet
Copy link

Thanks for the feedback! @jayantbh I’ll ensure certificates aren’t committed to the repo. I’ll also look into automating the renewal process as well! :)

@jayantbh
Copy link
Contributor Author

@not-meet it'll be a good idea to create a PR and go back and forth over that since we can be more implementation-specific there. Also, feel free to join our Slack community to discuss these things. :)

@jayantbh
Copy link
Contributor Author

@sikehish ^ same for you as well, if you're still interested.

@not-meet
Copy link

hi @jayantbh so i do changed the web-server from http1 to http2 while doing so i faced a small issue of my browser showing the connection is not secure... ill add a pr today so that we can go back and forth and finish the issue :)
and ya ! will be joining Slack community as well <3

@jayantbh
Copy link
Contributor Author

Sounds great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed web-server Issue related to web-server
Projects
None yet
Development

No branches or pull requests

4 participants