Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add schema update time verification for insert and upsert to use cache #39096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Jan 8, 2025

enhance: Add schema update time verification for insert and upsert to use cache
issue: #39093

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines. labels Jan 8, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JsDove
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
Copy link
Contributor

mergify bot commented Jan 8, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (aceb972) to head (580fb0c).

Current head 580fb0c differs from pull request most recent head f69e405

Please upload reports for the commit f69e405 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (aceb972) and HEAD (580fb0c). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (aceb972) HEAD (580fb0c)
8 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39096       +/-   ##
===========================================
- Coverage   81.18%   69.53%   -11.65%     
===========================================
  Files        1390      296     -1094     
  Lines      196755    26607   -170148     
===========================================
- Hits       159732    18502   -141230     
+ Misses      31442     8105    -23337     
+ Partials     5581        0     -5581     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.53% <ø> (ø)
Go ∅ <ø> (∅)

see 1094 files with indirect coverage changes

@JsDove JsDove force-pushed the schemacache branch 2 times, most recently from e9ddceb to 3185bf6 Compare January 9, 2025 02:30
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 9, 2025
@JsDove JsDove force-pushed the schemacache branch 2 times, most recently from ea21f5d to 580fb0c Compare January 9, 2025 03:22
… the cache

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

fix code

Signed-off-by: Xianhui.Lin <[email protected]>

fix test

Signed-off-by: Xianhui.Lin <[email protected]>
Copy link
Contributor

mergify bot commented Jan 9, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants