-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing moveit_task_constructor_msgs/SampleGraspPosesAction.h #281
Comments
Unfortunately, we didn't yet merge #196, which is the basis for the mentioned tutorial. Also, in #196 (comment) it was suggested to use an existing action instead of a new one. This essentially replaced
|
Hello, when I was reproducing the GPD algorithm, I followed the Deep Grasp Demo operation, but I encountered a missing header file error when compiling, how can I solve it? Hope you can help me! Thank you very much! |
@qyp-robot: Didn't my suggestion point you in the right direction? If not, please provide a detailed error description (error messages, your environment, etc.) |
Hello, when I make changes according to this, it can be compiled normally; [ INFO] [1626148048.631361699]: Generate grasp goal now active |
@bostoncleek, can you help on this issue? |
|
Thank you @rhaschke for the fast response! I have already merged the PR into my repo and now I am trying to modify the deep_grasp_demo package so it works with the changes. I am having some troubles with that:
Thanks again! |
I'm afraid I need to forward your questions to @bostoncleek. He implemented all this code originally. |
Thank you very much for your reply. I am also working on it. If you have the latest progress, please let me know in time. Thank you very much!
…------------------ 原始邮件 ------------------
发件人: "ros-planning/moveit_task_constructor" ***@***.***>;
发送时间: 2021年7月13日(星期二) 下午5:53
***@***.***>;
***@***.******@***.***>;
主题: Re: [ros-planning/moveit_task_constructor] Missing moveit_task_constructor_msgs/SampleGraspPosesAction.h (#281)
I'm afraid I need to forward your questions to @bostoncleek. He implemented all this code originally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
You should use GraspProvider in both moveit_task_constructor_(gpd and dexnet) packages. You will also need to update the tutorial and demo to use grasping_msgs::GraspPlanningAction. If GraspPlanningFeedback and Result are missing make sure you include the grasping_msgs::GraspPlanningAction action message in you code. Check out the action lib tutorials for help. If you have more questions please let me know. I am trying to get permission from my employer to update the demo and tutorial. But if you finish the modifications rhaschke made above please submit a PR and I will review it. |
Hi, I have created the PR so you can see the changes I've made. Thank you!! |
Hello @bostoncleek,@marcpujol-leitat,@rhaschke Do I also need to update the tutorial and demo to use grasping_msgs::GraspPlanningAction? |
Hi @qyp-robot, Now that you have solved the header problems, I think you have to modify the deep_grasp_demo so it works with the changes made in moveit_task_constructor according to the links you have sent. |
Thank you for your prompt reply!@marcpujol-leitat The demo to use grasping_msgs::GraspPlanningAction has been updated, but when I was compiling, an error occurred, such as: rror: ‘const struct grasping_msgs::GraspPlanningFeedback_<std::allocator >’ has no member named ‘grasp_candidates’ error: ‘const struct grasping_msgs::GraspPlanningFeedback_<std::allocator >’ has no member named ‘costs’ I checked carefully. In my /opt/ros/noetic/share/grasping_msgs/action, there is a file GraspPlanning.action. I don't know how to solve this compilation error. I hope you can help me! Thank you very much! |
During the changes you made in the moveit_task_constructor, you substituted the original action with GraspPlanningAction which no longer has "grasp_candidates" inside its feedback. You can find there message in the documentation: Grasp Planning Action |
Thank you very much!@marcpujol-leitat |
Hello, @marcpujol-leitat goal sent to clientstring action_nameresult sent to serverstring grasp_statefeedback sent to servergrasp posesgeometry_msgs/PoseStamped[] grasp_candidates cost of each graspfloat64[] costs But the information in GraspPlanning.action is this: This action is used when planning grasps for a single,already known object, one object at a time.Object for which grasp planning is requestedObject object Name of group to plan with (optional)string group_nameAll graspsmoveit_msgs/Grasp[] graspsGrasps found thus farmoveit_msgs/Grasp[] grasps In grape_provider.h, I am not quite clear about what information in GraspPlanning.action should be used to replace the original costs message, and what should be its action_name; I’m not sure how to change it, can you help me? Thank you! |
Hi @qyp-robot, If you go to my Pull Request you will see the changes I made to grasp_detection.cpp. However, it is still not working and I am waiting for bostoncleek to review the changes, so do not expect it to work propery. |
Thank you very much for your reply.@marcpujol-leitat |
Hello! @bostoncleek. |
Hi,@marcpujol-leitat [INFO] [1626318339.260666630]: Loading task parameters I am also very anxious. I have checked almost all the information but have not resolved it. Do you have any directions? Thank you! |
Hi @qyp-robot, This happens when you run moveit_task_constructor_demo demo.launch? It is working for me. Did you follow the tutorials? I am using Ubuntu 20.04 and ROS Noetic. In the same workspace I have the moveit_task_constructor I also have the moveit repository (noetic-devel) and panda_moveit_config. Hope it helps. |
Thank you for your reply!@marcpujol-leitat Then the terminal stays here all the time:
|
Hi@marcpujol-leitat Later, when compiling, the terminal reported an error and could not compile. Later, I made changes according to this: Compilation is successful, and then there is a problem with the above operation |
In my case it runs past where you are stuck and gets stuck somewhere else. I'm sorry but I don't know how to help you, the only thing I can tell you is to get bostoncleek's fork of moveit_task_constructor instead of the commit you are mentioning:
This way you will have the changes he made. |
Hello,@marcpujol-leitat I branched his pr-deep_grasp_stage code: Copy it to my workspace. At the moment, my workspace has the following 2 function packages: Compiled and can run the following two launches normally: So I think that the moveit_task_constructor function package and the basic repair are completed, and the problem may still be in the deep_grasp_demo function package. I will follow your prompts again to modify the code in the deep_grasp_demo function package. Is my understanding right? Thank you for your continued help. Thank you very much! |
Yes, I think we should wait for bostoncleek to review our changes. Well maybe @rhaschke could help with my issue, as it is a problem regarding the plan function of the class moveit::task_constructor::task After running the moveit_task_constructor_demo demo.launch and the moveit_task_constructor_gpd gpd_demo.launch, it looks like it is able to create the grasps and select the best ones but gets stuck there, not executing the task. I have checked the code and it gets stuck here, in the task_.plan(max_solutions) Where task_ is an object of the class moveit::task_constructor::task. Do you have any idea of why this may be happening? Thank you! |
Sorry, I don't know how to solve it at the moment, I will try it, and if there is any progress, I must contact you in time. Thank you |
Hello!@marcpujol-leitat An error occurred in the terminal, as shown below: ====> HAND SEARCH TIME: 0.340968 [grasp_cloud_detection-2] process has died [pid 533124, exit code -11, cmd /home/qyp/ws_grasp/devel/lib/moveit_task_constructor_gpd/grasp_cloud_detection __name:=grasp_cloud_detection __log:=/home/qyp/.ros/log/5adf923e -e603-11eb-a2be-5378e1583e88/grasp_cloud_detection-2.log]. The meaning here is that there is a problem with my point cloud search, but I have made the change according to your prompt: grasp_cloud_detection.cpp These two files have been changed and the compilation is successful, but the above error still appears, it seems that an error occurred during the point cloud processing; Is this a pcl problem? I follow this for pcl: |
My system configuration is the same as yours: |
Hi @qyp-robot, I can not really help much with that as you are not showing that much information... Maybe you should check the log that the error is pointing at, there you would find more information. Regarding PCL, I builded version 1.11 after downloading https://github.com/PointCloudLibrary/pcl/archive/pcl-1.11.0.tar.gz |
Hello,@marcpujol-leitat 1626423176.323402746 INFO /grasp_cloud_detection [/home/qyp/ws_grasp/src/deep_grasp_demo/moveit_task_constructor_gpd/src/grasp_detection.cpp:123(GraspDetection::goalCallback)] [topics: /genes,/grasrate, /genes /status] New goal accepted: object Then there is no more. I guess that the operation of grab_detection.cpp has stopped here. I don’t know why. My pcl is also version 1.11. Everything else should be the same as you. I don’t know why it stopped. I hope you Can help me, thanks! |
Hello!@marcpujol-leitat |
Hello, sorry, I need to trouble you again!@marcpujol-leitat The terminal has the following problems: In fact, the path of the conv1_weights.bin file is: But I can't find where to change this path, can you help me, thank you very much! |
Hi @qyp-robot This is explained in the deep_grasp_demo repository. Check point 5 of the GPD Installation. |
Thank you,@marcpujol-leitat It has been resolved, but I seem to have the same problem as yours, that is, after passing the GPD, I must have obtained the 94 best crawls, but after the score evaluation, the terminal stays here, as shown below Show: Grasp 89: 572.777
Hope to get your help, thank you very much for your continued help! |
It looks like we have the same problem now... Maybe we need to further modify the moveit_task_constructor_gpd as the planning phase gets stuck somewhere. My understanding of the code is not deep enough to know what to do so I will wait for @bostoncleek to review my repo. @qyp-robot if you manage to get it working or solve this problem, please keep me updated. Thanks! |
Hello,@marcpujol-leitat My approach is as follows:
|
Hello!@marcpujol-leitat |
I solved this and managed to run the demo using GPD. The issue is here. In the implementation of the grasp provider. At line 97 there is a request to lock a mutex, but the same mutex was already locked at line 161. I am not even sure why the mutex is needed, I removed both lines and the demo works like a charm. |
The GPD demo works now. Update by pulling the latest changes: |
Hi @bostoncleek I tried to build the demo with the new files from your branch and it seems that the file moveit/utils/moveit_error_code.h is not found in task_p.h . I saw this https://githubmemory.com/repo/ros-planning/moveit_task_constructor/issues/331 from @rhaschke . I tried to merge the branch on the master but I am not still not able to build. Is there is a way to find the file or to modify the dependency to build the demo ? Thank you. Errors << moveit_task_constructor_core:make /home/labcrvi/ws_grasp/logs/moveit_task_constructor_core/build.make.009.log |
@mathieugouletcrvi You should build the demo using the branch in PR 14. This is currently working on my end. Please let me know if you experience issues. The link you mention is broken. Let me know if the branch above doesn't work and I will look into that missing file. |
@bostoncleek Hi, I restarted with a clean work space for both ws_moveit and ws_grasp and took the branch in Unfortunatly, I still have a broken dependency from task_p.h on moveit/utils/moveit_error_code.h If I try to take the branch in PR 14 from moveit_task_constructor, there are other build errors. I copied the result at the end of my message. I am on ubuntu 18.04 and ROS melodic running on a virtualbox VM. Is there something else that I should try ? Thank you Profile: default
|
@mathieugouletcrvi, did you update your MoveIt installation? We have cut a new MoveIt release (1.0.9) into Melodic recently, which is not yet synced. Consider using the debians from the ROS |
@rhaschke Hi, I tried to use ROS testing repo. It still does not work... If I go with the master branch, I have error including SampleGraspPosesAction.h in grasp_image_detection.cpp and grasp_detection.h. The other error is still moveit_error_code.h missing from task.h. @bostoncleek Hi, If I use the testing repo with the PR14 branch, I still miss moveit_error_code.h in task.h. I found the file here : https://docs.ros.org/en/api/moveit_core/html/cpp/moveit__error__code_8h_source.html and pasted it in the same directory as task.h, changing the path to #include "moveit_error_code.h" With this, I am able to build all the package, but with this message [build] An internal error occurred! If I still try to run the demo, roslaunch moveit_task_constructor_demo demo.launch launch rviz with the panda robot with thie error [ INFO] [1643136263.170738920]: Using planning interface 'OMPL' If I try roslaunch moveit_task_constructor_gpd gpd_demo.launch . It does not work and gives this error message ERROR: cannot launch node of type [deep_grasp_task/deep_grasp_demo]: Cannot locate node of type [deep_grasp_demo] in package [deep_grasp_task]. Make sure file exists in package path and permission is set to executable (chmod +x) It is the same for roslaunch moveit_task_constructor_dexnet dexnet_demo.launch ERROR: cannot launch node of type [deep_grasp_task/deep_grasp_demo]: Cannot locate node of type [deep_grasp_demo] in package [deep_grasp_task]. Make sure file exists in package path and permission is set to executable (chmod +x) I will try on with noetic to see if I get the same result. Thank you. |
Hello, @rhaschke @bostoncleek may I ask, I have completed the linkage of panda robot model between moveit and gazebo, but when I start gazebo and moveit; and then start roslaunch moveit_task_constructor_gpd gpd_demo.launch; the page is as follows. GPD has solved the result; but the robot in gazebo is not moving; I am not sure if this task classifier is not sending the trajectory to gazebo? |
Hi @qyp-robot which branches have you used when you said : I have completed the linkage of panda robot model between moveit and gazebo. Is it : And Or have you used the setup assistant to generate the panda_moveit_config ? I opened this issue to discuss the topic : The best I have done so far was to operate the panda robot in rviz only, with dexnet and gpd, but the robot is still falling under gravity in gazebo and does not moved. Any help would be greatly appreciated. |
ok, i'll discuss it with you in time.@mathieugouletcrvi, |
I have seen solutions to this problem elsewhere, thank you very much |
I am trying to follow the moveit tutorials to install Moveit Deep Grasps but compiler fails saying this header is missing.
Is this intended and I need to replace them?
Thank you!
The text was updated successfully, but these errors were encountered: