New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode CSS can be imported twice on WNPs. #15772

Open

alexgibson opened this issue Dec 18, 2024 · 0 comments

Labels

Bug 🐛 P3

Member

alexgibson commented Dec 18, 2024

Description

Minor foot-gun here:

See: https://github.com/mozilla/bedrock/blob/main/media/css/firefox/whatsnew/whatsnew-135beta.scss#L8-L9

@import 'includes/dark-mode';
@import 'includes/mofo-donate-cta';

Note that _mofo_donate-cta.scss also imports dark-mode directly: https://github.com/mozilla/bedrock/blob/main/media/css/firefox/whatsnew/includes/_mofo-donate-cta.scss#L6

We should probably remove the dark_mode import from the donate scss, and make both explicit.

The text was updated successfully, but these errors were encountered:

alexgibson added Bug 🐛 P3 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment