Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use luasnip snippet text edit handler if available #420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: use luasnip snippet text edit handler if available #420

wants to merge 1 commit into from

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Jun 7, 2024

Closes #412

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@mrcjkb mrcjkb mentioned this pull request Jun 7, 2024
Open
@mrcjkb mrcjkb force-pushed the codeaction-snippettextedits branch from 7bbb5b5 to b780271 Compare June 7, 2024 10:02
@mrcjkb mrcjkb marked this pull request as draft June 7, 2024 10:09
@xzbdmw
Copy link
Contributor

xzbdmw commented Oct 29, 2024

Hey, when will this be merged :)

@mrcjkb
Copy link
Owner Author

mrcjkb commented Oct 29, 2024

@xzbdmw it's blocked by L3MON4D3/LuaSnip#235

@xzbdmw
Copy link
Contributor

xzbdmw commented Oct 29, 2024

For what I understand, Is it expected to wait until rust-lang/rust-analyzer#16604?

@mrcjkb
Copy link
Owner Author

mrcjkb commented Oct 29, 2024

For what I understand, Is it expected to wait until rust-lang/rust-analyzer#16604?

Yes.

@xzbdmw
Copy link
Contributor

xzbdmw commented Nov 2, 2024

Oh there will be a builtin one neovim/neovim#30287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Support for SnippetTextEdits in CodeAction
2 participants
@mrcjkb @xzbdmw