Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist protected mobs #94

Open
S-S-X opened this issue Mar 24, 2021 · 3 comments
Open

Blacklist protected mobs #94

S-S-X opened this issue Mar 24, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented Mar 24, 2021

Check object meta before jump and stop process if protected mobs found from area.

Or possibly move mobs but this should be tested well enough with all mobs that can be protected.
One way could be forcing on_move callback implementation for protected mobs, if method not found from definition then stop process. If found then call it, possibly even allow actively canceling jump if return value == false.

@S-S-X S-S-X added the enhancement New feature or request label Mar 24, 2021
@BuckarooBanzay
Copy link
Member

the problem with active objects is that they need to be active if they should appear in get_objects_inside_radius

i guess this would work currently for small ships but fails with large fleets

@S-S-X
Copy link
Member Author

S-S-X commented Mar 24, 2021

What happens when it fails, will objects still get removed even while mod cannot know that those exist?

@BuckarooBanzay
Copy link
Member

What happens when it fails, will objects still get removed even while mod cannot know that those exist?

i think thats part of the current problems (#91 and #89 partially) i haven't tested it but i guess the objects just don't appear in the list and don't get removed/moved... 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants