Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Can not open a folder in Jack Compiler #349

Closed
1 of 2 tasks
Arcadonauts opened this issue Jun 7, 2024 · 12 comments · Fixed by #419 · May be fixed by #354
Closed
1 of 2 tasks

[bug]: Can not open a folder in Jack Compiler #349

Arcadonauts opened this issue Jun 7, 2024 · 12 comments · Fixed by #419 · May be fixed by #354
Labels
bug Something isn't working

Comments

@Arcadonauts
Copy link

Tool

Jack Compiler

Interface

Website (https://nand2tetris.github.io/web-ide)

Contact Details

[email protected]

What happened?

I clicked the folder button in the Jack Compiler, expecting it to open the file dialog, but instead it did nothing. This is not an issue in the other views (CPU Emulator, Assembler, etc.)

Additional Comments

In the javascript console (Ctrl + Shift + i), the error is: Uncaught (in promise) TypeError: window.showDirectoryPicker is not a function

Do you want to try to fix this bug?

  • I want to try to add this feature!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Arcadonauts Arcadonauts added the bug Something isn't working label Jun 7, 2024
@DavidSouther
Copy link
Collaborator

Thank you for the bug report - could you confirm which browser and version you're using?

@Arcadonauts
Copy link
Author

Arcadonauts commented Jun 7, 2024

Oops! I thought I did.

Firefox 126.0.1 (64-bit) on Windows 10

@DavidSouther
Copy link
Collaborator

Thank you! I'm seeing this in another context, so we're going to disable the link to the Jack compiler until we get it sorted out.

@Arcadonauts
Copy link
Author

For what it's worth, I just tested it on Chrome on my machine and had no issues.

@Arcadonauts
Copy link
Author

I know this isn't the proper place to ask this question, but I'm not sure what is the proper place, so please excuse this violation:

As I've worked through the course, I've kept a private list of issues I've come across with the Web IDE. The list is about 20 items long, and I'd like to know the appropriate way to share it. Should I open 20 different issues? Should I open one big issue? Should I pick my top 3 (or 5 or 10) issues and just submit those?

The IDE is awesome, and I don't want to appear ungrateful for the hard work the team has put into it. What is the proper etiquette here?

@netalondon
Copy link
Collaborator

@Arcadonauts no worries, thanks for reaching out :)

The preferred way would be to open a separate issue for each item in your list.
No reason not to submit all of them.

@DavidSouther
Copy link
Collaborator

@Arcadonauts I see you starting to put in issues - thank you! We'll go through them, and we'll either work on a fix or let you know why we want the feature to be that way, and find another way to address your concern.

@Arcadonauts
Copy link
Author

@DavidSouther I really appreciate this amazing app, and I really hope the issues I opened don't leave you or anyone else with the impression that the Web IDE is anything short of amazing. Thank you for all your hard work!

@DavidSouther
Copy link
Collaborator

@Arcadonauts thank you for your kind words, and for your excellent bug reports. As a small project, the only way we find bugs we haven't seen is from community users like you who've taken it in different places than we expected! We'll get to work on these, and we might have more questions. If you have any interest in also doing some Typescript development, we'd love to see pull requests if you want to take a stab at fixing any of these yourself!

@DavidSouther
Copy link
Collaborator

(whoops wrong button, only meant to comment!)

@Arcadonauts
Copy link
Author

@DavidSouther "If you have any interest in also doing some Typescript development, we'd love to see pull requests if you want to take a stab at fixing any of these yourself!"

I have only a passing familiarity with Typescript, and all the low hanging fruit (e.g. #362) seems to be handled already by someone that almost certainly has more knowledge than I do, which is probably for the best.

I will, however, keep an eye out for any changes that I might be able to make.

@DavidSouther
Copy link
Collaborator

This should be better supported with the latest Local File System settings options. Please open a new feature request with suggestions to improve that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants