[bug]: Project 8 FibonacciElement test cases appear off by one

[maueroats]

Tool

General

Interface

None

Contact Details

No response

What happened?

I believe that the memory location of the return value from Fibonacci(4) should be 262 not 261.

See PR #546 for the VM version of this error.

There is a similar error in the Hack assembler version of the testing.

You should double-check this, since it seems suspicious that I am "discovering" this error at this point in the development.

Where is the master version of these files? I will be glad to file a PR against it.

Details

In the assembler version, SP=256 at the start.
Then the stack upon calling the Fibonacci function for the first time contains:

• the argument to Fibonacci, which is the number 4
• return address
• args, local, this, that

That means SP=262 at the start of the function call.

Both test scripts assert that the return value from the first Fibonacci function is at RAM[261], but I think it should be RAM[262].

Additional Comments

No response

Do you want to try to fix this bug?

• I want to try to add this feature!

Code of Conduct

• I agree to follow this project's Code of Conduct