Fix #63 "Convertion Failure" error #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #63
Hello @ncjoes this PR reverts #54 which causes errors for some people - as author stated, it shouldn't be merged as-is. Unfortunately relying on $_SERVER['HOME'] causes problems on some configurations (see my #63 (comment)). I think it would be better to revert it to make this library work again without errors.
May I ask you @ncjoes to merge this and release v1.0.8? Anyone who struggles with parallel execution problems (@caiosousaupp @trogau @rabol) could stick to v1.0.7 until some more reliable solution arrives. I don't want to make empty promises, but when I find some time I'll try to look at it.
Thank you!