Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty metrics report gets treated as an error #1662

Open
elinol opened this issue Nov 22, 2024 · 0 comments
Open

Empty metrics report gets treated as an error #1662

elinol opened this issue Nov 22, 2024 · 0 comments

Comments

@elinol
Copy link
Contributor

elinol commented Nov 22, 2024

When a device is reporting health with an empty metrics map, it gets treated as an error and triggers Logger.warning("Failed to save metrics").

See matching on result of Repo.insert_all in Metrics.save_metrics:

case results do
      {0, _} -> :error
      {count, _} -> {:ok, count}
 end
joshk pushed a commit that referenced this issue Dec 17, 2024
Solves #1662.

Also, the deprecated broadcast topic for health checks is replaced with the correct one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant