Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility around creating/updating tags #1727

Open
magixus opened this issue Jan 3, 2025 · 5 comments
Open

More flexibility around creating/updating tags #1727

magixus opened this issue Jan 3, 2025 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@magixus
Copy link

magixus commented Jan 3, 2025

Describe the bug
At the moment, when trying to add/update tags it's a bit complicated, you have to set a comma separated list of tags, if you wanna update, it's not adding your existing tags to the list. (you have to rewrite them)

To Reproduce
Steps to reproduce the behavior:

  1. Go to devices
  2. Checkbox a device that contains tags
  3. Try to Update

Expected behavior
We should be able to have a little bit of flexibility when updating tags, like be able to find same tags and be able to update them. (remove, add)

Example:
image

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux Mint 22
  • Browser : Google Chrome (latest)
  • Version : Nerves hub cloud
@nshoes nshoes added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2025
@joshk
Copy link
Collaborator

joshk commented Jan 3, 2025

I'm not sure I agree with this change. If you are to select three devices, which tags should be prepopulated?

I think the UI you showed is lovely, and we should add it, but I don't think the set tag(s) to should have tags automatically added to it.

@nshoes
Copy link
Contributor

nshoes commented Jan 3, 2025

@joshk good point, you're correct. IMO this UI should be implemented on the device settings page.

@magixus
Copy link
Author

magixus commented Jan 3, 2025

good point @joshk.
I was thinking about it before writing this issue, and I hoped you guys will make improvements to the UI and keep bulk tags updates as it is.

Here's my suggestion:
if one device is selected => copy same tag with enhanced UI
if multiple selection => keep tags empty.

@gBillal
Copy link

gBillal commented Jan 3, 2025

What about a way to add tags instead of setting them ? Imagine having 10 or 100 devices with a set of tags (there's a unique tag per device), and you want to add a common tag, in this case, you need to add the tag to the devices one by one otherwise you risk resetting all of them.

@joshk
Copy link
Collaborator

joshk commented Jan 6, 2025

@magixus I think this suggested behaviour would be a little confusing for people. Seeing the tags list populate and then become empty would be confusing; at least, it would be for me. Feature behaviour should be consistent, and this would break that rule.

@gBillal This is an interesting request. Could you please split it out into another issue for discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants