Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node name for ControllerLink with StringPalette #77

Open
HENDRIX-ZT2 opened this issue Sep 26, 2021 · 0 comments
Open

Set node name for ControllerLink with StringPalette #77

HENDRIX-ZT2 opened this issue Sep 26, 2021 · 0 comments

Comments

@HENDRIX-ZT2
Copy link
Contributor

@niftools/pyffi-reviewers

Issue Overview

All controller links should set on the parent controller's palette. Don't create a palette for each controller link.

see niftools/blender_niftools_addon#463 for a fix on the blender plugin side

Version Information

Pyffi Version Info

current master / dev

Platform information

[Provide a brief overview of what OS your running on]

Context

[Provide more detailed information to the issue itself]

Steps to Reproduce

[Ordered list of the steps required for recreating the issue, including settings]
#.

Expected Result

ControllerLink.set_node_name()
should set:
self.target_name (for older games that do not use the palette)
self.node_name
self.node_name_offset
and write to a shared palette

Actual Result

the linked pyffi for the plugin does not set self.target_name
a new palette is created for each controlled block

Possible Fix

[Optional, suggest fixes, improvement or reasons for the bug might have occurred]

Screenshot

[If relevant, include a screenshot]

Logs and Files

[Provide the generated log output and any accompanying files for the format related to the issue]

Console Output

[Set the logging level to 'Debug' and attach the output of the console. ]

Similar Known Issues

[Reference any known issues - https://github.com/niftools/pyffi/issues]

Additional Information

[Anything else you feel is relevant]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant