Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent formatting when reading multiple XLS files concurrently (#1469) #1470

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Inconsistent formatting when reading multiple XLS files concurrently (#1469) #1470

wants to merge 3 commits into from

Conversation

Vemahk
Copy link

@Vemahk Vemahk commented Jan 4, 2025

Fixes #1469 by reverting 96186d6.

I intend to do a more thorough look at how to get that performance back and redo the caching... This was just the fastest solution after writing the test and benchmark.

Benchmark

BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.5247/22H2/2022Update)
AMD Ryzen 5 1600X, 1 CPU, 12 logical and 6 physical cores
.NET SDK 9.0.101
  [Host]     : .NET 6.0.36 (6.0.3624.51421), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.36 (6.0.3624.51421), X64 RyuJIT AVX2

Before

Method RowCount Mean Error StdDev
Read 1000 7.045 ms 0.1364 ms 0.1675 ms

After

Method RowCount Mean Error StdDev
Read 1000 9.296 ms 0.1820 ms 0.2302 ms

Math

Looks to be a 32% regression in performance. Pretty bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent formatting when reading multiple XLS files concurrently
1 participant
@Vemahk