-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create LanguageDropDown
component
#5981
Comments
Hi @bmuenzenmeyer, I would love to work on this, can you please assign me this so that I can start the development? Thanks! |
@bmuenzenmeyer nevermind about assigning, I just got to know you guys don't assign the issues, FYI I'm still working on this. |
Also, for the Storybook, feel free to add mocked language options to the Dropdown, we don't need to get the real Dropdown options (Available Languages) for the Storybook. |
It would also be interesting to add Unit Tests to ensure that onClick behaviour actually renders the Dropdown |
@ovflowd I am working on the model but not able to preview what I am building can you pls. help for that |
Read the Contribution Guidelines. It's all documented there. I'm not going to provide 1:1 support, sorry. (I don't have time for that) |
OkayJi 🥺 |
But is there anything specific that is not working? To preview changes you simply need to run |
Hey, I was already working on this. As issues are not assigned, I didn't leave any comments. |
Create a
LanguageDropDown
component using the new figma design (direct link).This component is an icon-button that when activated shows a dropdown of all locales. This is the final port of the LanguageDropDowncomponent recently deleted. Much of the functionality is the same to end users, but with different tech.
Before You Start...
Details
❓ Not sure where to start breaking down the figma? Read this short guide
🌐 This story requires some internationalization support. Slow down!
LanguageDropDown
within theCommon
directory that contains all the new code.@radix-ui/react-dropdown-menu
for the accessible foundation and functionality we need.DropdownMenu.Trigger
to place the icon and button@heroicons/react
module has the iconlanguage
available for use.components/Common/LanguageDropDown/index.stories.tsx
which exercises each of the component's states.aria-label
must be internationalized, and in English stateChoose Language
. Add a new keycomponents.common.languageDropdown.label
to thei18n/locales/en.json
file.useIntl
fromreact-intl
should be used to reference the key. Look for examples elsewhere in the codebase or in the old PR.There are 2 states to capture within styles and stories:
The text was updated successfully, but these errors were encountered: