Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub Workflow for Running Unit Tests #36

Open
Cliftonz opened this issue Sep 24, 2023 · 3 comments
Open

Setup GitHub Workflow for Running Unit Tests #36

Cliftonz opened this issue Sep 24, 2023 · 3 comments

Comments

@Cliftonz
Copy link
Contributor

In order to ensure the stability and reliability of our codebase, it is essential to have automated unit tests running for each push and pull request. Currently, our repository lacks a GitHub Actions workflow to run unit tests, and this needs to be addressed to maintain code quality and catch issues early.

Suggested Solution:

  1. Create a new workflow file in .github/workflows/ directory.
    Filename: run-unit-tests.yml

  2. Configure the workflow to be triggered on every push and pull_request event to the main branch.

  3. Define job steps:
    Checkout the repository.
    Setup the environment/java runtime.
    Install dependencies.
    Run the unit tests.

@amirali-ashraf
Copy link
Contributor

@Cliftonz I think I can pick this up if you are still interested. Thanks

@amirali-ashraf
Copy link
Contributor

@muhammadnawzad thanks for picking it.

Do you think we need to add other ruby versions to the set or we are good with only having jruby to test it?

@muhammadnawzad
Copy link
Contributor

Running the tests on multiple versions is definitely more beneficial. Initially, I planned on running the tests on different versions but since the gem pry-debugger-jruby is a dependency. Jruby is the only version that can be used to run the test. I recommend moving pry-debugger-jruby out of the gemfile since this is a development tool and enabling tests on different ruby versions. However I leave the decision to the active contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants