Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to newer SVD's and svd2rust / breaking changes #20

Open
dbongartz opened this issue May 29, 2024 · 0 comments
Open

Updating to newer SVD's and svd2rust / breaking changes #20

dbongartz opened this issue May 29, 2024 · 0 comments

Comments

@dbongartz
Copy link

dbongartz commented May 29, 2024

Hi everyone,

I recently stumbled across the missing APPROTECT and some other registers while I was used to have them from developing on NCS/Zephyr.

So I had a look and upgraded those in a fork.
While at it I realized that svd2rust made some significant progress since 0.25.x.

Just to try it out I upgraded this pac to the newest svd2rust which introduces breaking changes. Most of which are fixed by search and replace in the HAL and probably not exposed to the end user of the HAL.

You can see a working version for nrf52840 (did not check others) here:

I tried to keep the old naming conventions and exports of svd2rust but we could also think about moving to the current defaults instead. (Again, search and replace in the HAL)

Question

Is this a wanted change or is it considered too big / needs more coordination?


I have some time to spend on this in the next weeks if this is considered a good idea :)

Best,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant