-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predefined & documented ENS name ownership condition #104
Comments
|
Is the idea for this issue only to address name resolution on the client-side (i.e. at encryption time, just use the resolved wallet address in place of the ens name), or is there an associated server-side change that is expected. If the idea is only to do name resolution at the client side (i.e. at encryption time), then one limitation is that it would prevent any updating of the ens domain to point to a different wallet address after the fact. Obviously, changes on the server side require updates across the network, but aside from that, the actual code change is probably not that difficult - https://web3py.readthedocs.io/en/stable/ens_overview.html#ethereum-name-service-ens. |
I think there are two different functionalities, that we may or may not want to bundle together:
Edit: I think we can do both as long as we communicate that |
Indeed. And for the first one i.e. on client-side replace Unless, we make server-side changes to actually handle ens addresse so that they can be allowed in the condition and properly processed by the node i.e. the second one. |
AFAIK this is the goal of this issue. I have created a new issue for the other idea: #512 |
After a chat about this with @piotr-roslaniec, we came to some conclusions: There are different use cases:As Piotr realized, there are at least two different use cases that will require ENS:
We cannot use the current TACo conditions, but there are some alternativesThe first attempt was to use a To make an ENS lookup (nick.eth -> 0x241df23...) we have to do two calls to two different contracts:
This is not straightforward to do with the current conditions on taco-web. But there are several alternatives:
(@piotr-roslaniec pseudo-code)
So, to fix this we may need to introduce a new, "blank" context parameter that will be substituted by contract return value during condition evaluation:
The last one can be useful not only for the ENS integration but for further use cases in which we need to ask for some data in the blockchain before checking the condition. |
No description provided.
The text was updated successfully, but these errors were encountered: