Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swig %pythonbegin instead of PREPEND_BOILERPLATE_TO_PYTHON_PROXY_MODULE #1043

Open
vitaly-krugl opened this issue Aug 16, 2016 · 0 comments

Comments

@vitaly-krugl
Copy link
Member

PR #1030 added PREPEND_BOILERPLATE_TO_PYTHON_PROXY_MODULE to prepend the necessary boilerplate python code and file header from src/nupic/bindings/swig_proxy_preamble.py to the swig-generated python proxy modules.

I later learned that this can be accomplished via the Swig element %pythonbegin in the corresponding .i files instead of creating custom commands during the build.

The idea is that the solution should include the shared src/nupic/bindings/swig_proxy_preamble.py contents, but not copy-paste them into the .i files. Copying manually to various .i files is bad for maintainability, so don't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants