Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have nupic.core build output a shared library artifact instead of the static lib #1217

Open
vitaly-krugl opened this issue Jan 24, 2017 · 0 comments
Assignees

Comments

@vitaly-krugl
Copy link
Member

Currently, nupic_core_solo is a static library and gets repackaged with the external dependencies into a combined static library that the binaries and Python extensions link to.

This change is to:

  • Remove the combined nupic_core static library
  • Change nupic_core_solo to a shared library and include the external dependencies for linking
  • Change the extensions to dynamically link to the nupic_core shared library
  • It looks like the logical place to put the Python-specific files (called {{src_py_support_files}} in {{src/CMakeLists.txt}}) is in nupic_core_solo but it may be better to leave them out and include them when compiled the Python extensions since they aren't really part of the C++ API that we want to expose in the shared library. But whoever is looking into this can make a judgement call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant