Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] allow path to a directory containing a manifest or a manifest as a Config::server() #284

Open
mrcjkb opened this issue Dec 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Dec 28, 2024

luarocks allows you to pass a directory containing a manifest (or a path to a manifest, I don't recall) as a --server.
This can be useful for local debugging. We should support it too.

@mrcjkb mrcjkb added the enhancement New feature or request label Dec 28, 2024
@mrcjkb mrcjkb changed the title [Feature] allow path to a directory containing a manifest or a manifest as a Config.server() [Feature] allow path to a directory containing a manifest or a manifest as a Config::server() Dec 28, 2024
@vhyrro
Copy link
Contributor

vhyrro commented Dec 29, 2024

I don't like having too many flags but --local-server could be a nice way of fragmenting the code to prevent spaghetti? Then we can add a parser to clap to ensure that --server is a well-formed URI. I always hated luarocks's "do everything in one go" approach to the CLI.

@mrcjkb
Copy link
Member Author

mrcjkb commented Dec 29, 2024

I like the idea.

Edit - Thought: a well-formed URI can also be file://.... How would we handle that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants