Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] rocks typecheck #290

Open
vhyrro opened this issue Dec 29, 2024 · 5 comments
Open

[Feature] rocks typecheck #290

vhyrro opened this issue Dec 29, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vhyrro
Copy link
Contributor

vhyrro commented Dec 29, 2024

Pondering whether this should be a builtin part of rocks check...

This command would first ensure that lua-language-server is installed, then install llscheck and run that on the codebase.

@vhyrro vhyrro added enhancement New feature or request good first issue Good for newcomers labels Dec 29, 2024
@mrcjkb
Copy link
Member

mrcjkb commented Dec 29, 2024

I think it would make sense to add flags for enabling or disabling luacheck and llscheck.
lua-language-server currently doesn't exist as a luarocks package, but perhaps we could open a PR to get it packaged?

I've had some issues with llscheck. Perhaps it would be better to implement the wrapper in rust, which would also make it easier to pin a compatible lua-language-server version?

@vhyrro
Copy link
Contributor Author

vhyrro commented Dec 29, 2024

There are problems with packaging lua-ls unfortunately :(

I've bent llscheck pretty far and haven't had it snap on me yet. Anything specific? I'd be happy to implement a wrapper either way.

@vhyrro
Copy link
Contributor Author

vhyrro commented Dec 29, 2024

About the rust rewrite of lua-ls, it seems to be stale (last update was 2 months ago). Maybe one day we'll be able to vendor it with rocks just like we did stylua :p

@mrcjkb
Copy link
Member

mrcjkb commented Dec 29, 2024

I wouldn't say 2 months is stale.
They might just be taking a break.

What if we package bee.lua for luarocks? 😉

I've bent llscheck pretty far and haven't had it snap on me yet. Anything specific? I'd be happy to implement a wrapper either way.

I tried to get it to work with lua-typecheck-action and it just won't.

@vhyrro
Copy link
Contributor Author

vhyrro commented Dec 29, 2024

If we could figure out how to get bee.lua on luarocks then that would be pretty great 🗣️ 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants