Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support mini.icon library #1472

Open
pidgeon777 opened this issue Jul 13, 2024 · 1 comment
Open

[Feature] Support mini.icon library #1472

pidgeon777 opened this issue Jul 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pidgeon777
Copy link

Is your feature request related to a problem? Please describe.
This icons library was released recently:

https://github.com/echasnovski/mini.icons

It seems to be better than:

https://github.com/nvim-tree/nvim-web-devicons

Describe the solution you'd like
It would be great if lspsaga.nvim also could support the mini.icons library.

Describe alternatives you've considered
None

Additional context
The mini.icons library has already been integrated into popular Neovim distributions such as LazyVim, with great results.

@pidgeon777 pidgeon777 added the enhancement New feature or request label Jul 13, 2024
@stevenxxiu
Copy link

stevenxxiu commented Sep 5, 2024

Here's a way to patch this for now:

config = function(_, opts)
  -- Patch to use *mini.icons*
  require('lspsaga.util').icon_from_devicon = function(ft) return require('mini.icons').get('filetype', ft) end

  require('lspsaga').setup(opts)
end,

It'll be better to make this a config option of course, like in bufferline's options.get_element_icon. bufferline supplies the arguments: directory, extension, filetype, path, type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants