Crash on Windows Debug Build #134
Comments
|
That's to free the memory allocated in Node.js, where the malloc() call is actually done by HeapAlloc() in CRT. free() can't be used here because it's intercepted by allocator shim in Chromium. It seems that something changed in latest Chromium in debug build. I think we need better conditional macros to handle this case. |
rogerwang
pushed a commit
that referenced
this issue
Feb 10, 2019
This CL styles the parts of document results’ descriptions which match the
user input. E.g., given the user input 'rain if you dare', and a document
titled 'how to tell if your kitten is a rainbow', the result should display
"if", "you" in "your", and "rain" in "rainbow" as bolded:
how to tell if your kitten is a rainbow
^^ ^^^ ^^^^
Bug: 925483
Change-Id: I4c0f255ae5bbefa57e9980ade626efac69a76a18
Reviewed-on: https://chromium-review.googlesource.com/c/1435983
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626773}(cherry picked from commit 7c3b973)
Reviewed-on: https://chromium-review.googlesource.com/c/1450469
Reviewed-by: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#134}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this issue
Mar 24, 2019
This patch shows vertical bar icons when there are consecutive
Assistant icons.
We have the following situations:
Number of consecutive Assistant items -> icons
1 item -> Assistant icon.
2 items -> Assistant icon + single vertical bar icon.
3 items -> Assistant icon + start + end vertical bar icons.
n >= 4 items -> Assistant icon + start + middle (n - 3) + end vertical bar
icons.
[email protected], [email protected]
Bug: 924624, 940225
Test: manual
Change-Id: I125baae5eff801fee01c6c1471e2d0ee6bf7666e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510770
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#640008}(cherry picked from commit cd1861996c45a58b102e215da7ff99e47757fbdd)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525010
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3729@{#134}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rogerwang I am experiencing crash issue with Windows DEBUG build, on this line:
chromium.src/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 686 in 9fece9b
if I disable the ::HeapFree and just use "free", everything looks fine
any reason why you are using HeapFree? I can't find the correspondent HeapCreate
The text was updated successfully, but these errors were encountered: