New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong browser_version detection for Chrome-based Googlebot #153

Open

eserte opened this issue Dec 26, 2018 · 0 comments

Labels

Bug

eserte commented Dec 26, 2018

$ perl -MHTTP::BrowserDetect -E 'say HTTP::BrowserDetect->new(shift)->browser_version' "Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5X Build/MMB29P) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.96 Mobile Safari/537.36 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)"  
2.1

I would expect "41.0" here.

It seems that this is caused by getting a successful match here: https://metacpan.org/source/OALDERS/HTTP-BrowserDetect-3.20/lib/HTTP/BrowserDetect.pm#L1812
Maybe this check should be done later, or be done for specific browsers only (probably MSIE, but what are "some others"?).

The text was updated successfully, but these errors were encountered:

oalders added the Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment