-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
also install signatures.{cmi,cmti} #227
also install signatures.{cmi,cmti} #227
Conversation
In fact I was a bit too optimistic about the usability of those languages. OCaml pull-requests (that pull from ocamlbuild master) are now failing with:
Oh well. Will fix. |
@gasche How did this happen? |
Mmmh sorry about the merge then. It's strange the CI was saying yes. Is due to a lack |
I'm just as confused (no need to apologize!); |
The OCaml CI seems to be failing with errors related to the signatures.{mli,cmi,cmti} (un)install rules introduced in PR ocaml#227 ( 1c83750 ): https://s3.amazonaws.com/archive.travis-ci.org/jobs/208163203/log.txt ``` cp META src/signatures.{mli,cmi,cmti} /home/travis/local/lib/ocamlbuild cp: cannot stat `src/signatures.{mli,cmi,cmti}': No such file or directory make[1]: *** [install-lib-basics] Error 1 ``` I don't really understand what the problem is; to me it looks like the `.{mli,cmi,cmti}` pattern is not recognized (by this seems to be a genuine `bash` running?!), so this commit uses separate files instead. Hopefully, even if the cause of the issue is something else (for example one of these files may be missing for some reason and the error message is just bad), the split in separate filenames may help diagnose it.
Actually when I saw it I wanted to comment that it is a bashism but then thaught that this might be supported by the |
The OCaml CI seems to be failing with errors related to the signatures.{mli,cmi,cmti} (un)install rules introduced in PR ocaml#227 ( 1c83750 ): https://s3.amazonaws.com/archive.travis-ci.org/jobs/208163203/log.txt ``` cp META src/signatures.{mli,cmi,cmti} /home/travis/local/lib/ocamlbuild cp: cannot stat `src/signatures.{mli,cmi,cmti}': No such file or directory make[1]: *** [install-lib-basics] Error 1 ``` I don't really understand what the problem is; to me it looks like the `.{mli,cmi,cmti}` pattern is not recognized (but this seems to be a genuine `bash` running?!), so this commit uses separate files instead. Hopefully, even if the cause of the issue is something else (for example one of these files may be missing for some reason and the error message is just bad), the split in separate filenames may help diagnose it.
Hopefully fixes #217.