You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd always run it with npm run build --if-present, just like the others. This makes sure that we verify that the dependencies only used for building are tested as part of the CI
npm run validate:ts
npm run test:typescript
npm run test:ts
I'm tending towards test:tsc to be as clear as possible. In other project I use test:tsd for type-only tests using tsd, and in future when I hope me move away from TS source code I could imagine @octokit to use that, too (Example)
But I'm open to anything, it's not set in stone. I do agree we should normalize it across the @octokit repositories though
I'd always run it with
npm run build --if-present
, just like the others. This makes sure that we verify that the dependencies only used for building are tested as part of the CII'm tending towards
test:tsc
to be as clear as possible. In other project I usetest:tsd
for type-only tests usingtsd
, and in future when I hope me move away from TS source code I could imagine @octokit to use that, too (Example)But I'm open to anything, it's not set in stone. I do agree we should normalize it across the @octokit repositories though
Originally posted by @gr2m in octokit/.github#13 (comment)
The text was updated successfully, but these errors were encountered: