Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document in download_raw_data.sh instructions when wget not installed #3

Open
erictleung opened this issue Nov 8, 2019 · 3 comments

Comments

@erictleung
Copy link
Member

What is more sustainable and reasonable?

  1. Convert the script to use curL
  2. Document what happens when wget is not installed
  3. Account for the possibility that one or the other is not installed, so use the other (e.g., https://stackoverflow.com/a/52651894/)
@abalter
Copy link
Contributor

abalter commented Nov 8, 2019

What about something like this:

if has wget:
    use wget
elseif has curl:
    use curl
else:
    print("go get a real OS")

@erictleung
Copy link
Member Author

@abalter yeah, I figured something like that would work.

We have the code for using wget, but I'm not sure off the top of my head what the parameters are for curl that would mirror the same functionality with wget.

This is really low priority, so we don't have to solve this right away. But if one of us has time, we can work on this wget-to-curl translation.

@abalter
Copy link
Contributor

abalter commented Nov 8, 2019

With curl, download the file as opposed to print to screen you use the -O flag. Alternatively, you can just redirect.

curl -O https://raw.githubusercontent.com/ohsu-microbiome/utilities/master/download-utilities/download_raw_data.sh

curl https://raw.githubusercontent.com/ohsu-microbiome/utilities/master/download-utilities/download_raw_data.sh > download_raw_data.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants