Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic notification support #2459

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Basic notification support #2459

wants to merge 14 commits into from

Conversation

corrideat
Copy link
Member

Closes #2455

@cypress Cypress
Copy link

cypress bot commented Dec 15, 2024 •
edited
Loading

group-income    Run #3629

Run Properties:  status check passed Passed #3629  •  git commit 8d8376f81c ℹ️: Merge 2612cf816bd797e82424ff1d8d4c41ad1502d2cb into 25c49c96a96d0b6aa6367fa30329...
Project group-income
Branch Review 2455-implement-push-notifications-for-notifications-in-templatesjs
Run status status check passed Passed #3629
Run duration 10m 45s
Commit git commit 8d8376f81c ℹ️: Merge 2612cf816bd797e82424ff1d8d4c41ad1502d2cb into 25c49c96a96d0b6aa6367fa30329...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@corrideat
Copy link
Member Author

So far:

  1. Augment templates.js with fields specific to native notifications (I think at least title and body, possibly also icon).

TBD after discussion.

  1. Modify gi.notifications/emit or define an event handler for NOTIFICATION_EMITTED calling makeNotification.

Using NOTIFICATION_EMITTED.

  1. Solve the currentGroupId issue for group-scoped native notifications (relevant for when the native notification is clicked)

Solved for existing windows, not solved yet when opening a new window.

  1. Implement periodic notifications by either waking up the service worker at regular intervals or through on-demand wake up requests.

Not done.

In addition, this remains:

  1. If not augmenting templates.js with body, find a way to strip the HTML tags
  2. Replace @contractID with @username or display name as in-app notifications do.

@corrideat corrideat force-pushed the 2455-implement-push-notifications-for-notifications-in-templatesjs branch 3 times, most recently from 9bccb54 to 9b33971 Compare December 26, 2024 15:53
@corrideat corrideat force-pushed the 2455-implement-push-notifications-for-notifications-in-templatesjs branch from 9b33971 to 9a43338 Compare December 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement push notifications for notifications in templates.js
2 participants
@corrideat @taoeffect