Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is thrown if UserIdentifierConditionEvaluatorPattern is empty #392

Open
louiecampagna-okta opened this issue Jun 15, 2023 · 2 comments
Labels
bug Something isn't working stale Triaged

Comments

@louiecampagna-okta
Copy link

Describe the bug?

Api validation failed: mediationRule. Causes: errorSummary: The condition 'userIdentifier' must have 'patterns'.

omitempty on UserIdentifierConditionEvaluatorPattern prevents requests being made with a blank pattern value; if a policy rule is retrieved, it can have a blank value for the pattern. If the policy rule is updated, a valid policy rule with a blank pattern will throw an error trying to update.

Updating userIdentifierPolicyRuleCondition.go to remove omitempty resolves the issue

What is expected to happen?

Expected behavior would be for the policy rule to update successfully even with a blank value for the pattern

What is the actual behavior?

Api validation failed: mediationRule. Causes: errorSummary: The condition 'userIdentifier' must have 'patterns'.

Reproduction Steps?

Update a policy rule via golang SDK that has a blank value for the user identifier patterns

Additional Information?

No response

Golang Version

go version go1.19.2 darwin/amd64

SDK Version

2.17

OS version

Darwin C02G12VPML85 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64

@louiecampagna-okta louiecampagna-okta added the bug Something isn't working label Jun 15, 2023
@duytiennguyen-okta
Copy link
Contributor

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-620369

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Triaged
Projects
None yet
Development

No branches or pull requests

2 participants