Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors containing PII from search terms #432

Open
craigpastro opened this issue Feb 23, 2024 · 1 comment
Open

Errors containing PII from search terms #432

craigpastro opened this issue Feb 23, 2024 · 1 comment
Labels
enhancement New feature or request stale

Comments

@craigpastro
Copy link

Describe the feature request?

The error messages from the SDK wrap the API error, which sometimes contains PII from the search term. For example, from the users API, if I try to get a user from their email address, Get User will return something like

the API returned an error: Not found: Resource not found: EMAIL (User)",

if that particular user is not found.

It also happens that if the context is cancelled somehow the entire endpoint is returned which again may contain a search term like an error. E.g.,

Get "https://accounts-api.brex.com/api/v1/users?search=profile.login+eq+EMAIL": context deadline exceeded

In both of these cases, the error message could be logged downstream which is not great. So, I suppose, what I would like is to either not have the search term returned in the error or an easy way to extract the essence of the error so I can convert to my own error. I guess I can convert the error to an *okta.Error and use the error code, but that wouldn't work in the second case above. At the moment I am matching on substrings which isn't ideal, but works.

Any better suggestions? Thanks!

New or Affected Resource(s)

All of them.

Provide a documentation link

No response

Additional Information?

No response

@craigpastro craigpastro added the enhancement New feature or request label Feb 23, 2024
Copy link

github-actions bot commented Mar 9, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant