Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise MSVC warning level from /W3 to /W4 #2342

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Nov 18, 2024

This reinstates the reverted changes in #2100 which were reverted in #2302 due to regressions in intel/llvm testing.

Fixes #2305

@github-actions github-actions bot added loader Loader related feature/bug common Changes or additions to common utilities conformance Conformance test suite issues. images UR images specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 18, 2024
This reinstates the reverted changes in oneapi-src#2100 which were reverted
in oneapi-src#2302 due to regressions in intel/llvm testing.
@kbenzie kbenzie force-pushed the benie/windows-reinstate-warning-level-4 branch from e73da20 to e214245 Compare November 20, 2024 12:16
@kbenzie kbenzie changed the title Revert "Merge pull request #2302 from callumfare/callum/revert_ur_2100" Raise MSVC warning level from /W3 to /W4 Nov 20, 2024
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Nov 20, 2024
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Nov 21, 2024
@kbenzie kbenzie closed this Dec 18, 2024
@kbenzie kbenzie deleted the benie/windows-reinstate-warning-level-4 branch December 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues images UR images level-zero L0 adapter specific issues loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-land #2100 (Raise MSVC warning level from /W3 to /W4)
1 participant