Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlqueryreceiver lacks integration tests for mssql #29695

Open
cwegener opened this issue Dec 7, 2023 · 6 comments · May be fixed by #36922
Open

sqlqueryreceiver lacks integration tests for mssql #29695

cwegener opened this issue Dec 7, 2023 · 6 comments · May be fixed by #36922
Labels
never stale Issues marked with this label will be never staled and automatically removed receiver/sqlquery SQL query receiver test coverage Improve test coverage

Comments

@cwegener
Copy link
Contributor

cwegener commented Dec 7, 2023 •
edited
Loading

Component(s)

receiver/sqlquery

Describe the issue you're reporting

When submitting #29694 I noticed that only Oracle, Postgres and MySQL are currently covered with integration tests.

Adding MSSQL as another popular RDBMS to the existing integration tests should be considered
@cwegener cwegener added the needs triage New item requiring triage label Dec 7, 2023
@github-actions github-actions bot added the receiver/sqlquery SQL query receiver label Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added the test coverage Improve test coverage label Dec 7, 2023
@crobert-1
Copy link
Member

Good idea, and I believe this would be the best place to put it.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Dec 7, 2023
@cwegener
Copy link
Contributor Author

cwegener commented Dec 7, 2023

Good idea, and I believe this would be the best place to put it.

Yes. The existing scaffolding for the IMDB test queries should hopefully just work for MSSQL as well for doing the metrics testing.

I'm not sure if it's the right time yet to add integration tests for the logs data as well. I guess it wouldn't hurt to add that in too.

@cwegener cwegener mentioned this issue Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this issue Dec 12, 2023
Closed
95 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 6, 2024
@crobert-1 crobert-1 removed the Stale label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@crobert-1 crobert-1 removed the Stale label Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 10, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 10, 2024
@Grandys Grandys linked a pull request Dec 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
never stale Issues marked with this label will be never staled and automatically removed receiver/sqlquery SQL query receiver test coverage Improve test coverage
Projects
None yet
Milestone
No milestone
2 participants
@cwegener @crobert-1