[chore] [cmd/builder] pin ocb go.mod template to 1.22.0 #11845
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgopack4
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11845 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 446 446
Lines 23743 23743
=======================================
Hits 21745 21745
Misses 1623 1623
Partials 375 375 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Dec 11, 2024
dmitryax
approved these changes
Dec 14, 2024
|
@jackgopack4 thanks! This should also fix an issue when CI starts failing once a new patch version of go is released: |
|
Please rebase so we can merge this |
|
I'm not sure this is the best way to fix it; it would require anyone running OCB to use go 1.22.0; apparently (linked in the issue) 1.22 is actually a valid go.mod but it was something that was broken then fixed in a recent version of both 1.22 and 1.23. That's why I left this as a draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pins go.mod in ocb template to 1.22.0 to match latest Golang standard (golang/go#62278)
Link to tracking issue
Fixes #11844
Testing
pipeline tests should suffice
Documentation
none, bugfix