-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expvar handler to zpages extension #11081
Comments
Hi @yurishkuro, I'd like to try this one, it seems a good opportunity to understand the zpage extension implementation. |
@HongChenTW go for it. I temporarily created an internal extension in Jaeger as a workaround jaegertracing/jaeger#5986 |
Hi @yurishkuro , after digging into code, I found that I could register the expvar handler to expose the expvar pages at here, with some adjustments(declare the e.g. But I also noticed other components in zpages extention draw html pages like tracez or featurez, should I also design a html template to render the expvar, could you give some advises? Thanks! |
@HongChenTW I would start with just the default, out of the box |
resolve open-telemetry#11081 Signed-off-by: Hong Chen <[email protected]>
Hello colleagues, |
Yes |
Hi, I'd like to work on it. |
Hi @yurishkuro , could you help to check this PR #11217 if is mergeable? I'm not sure whether the implementation is suitable for the requirements in this issue, also, since this PR was created few months ago, could you help to guide how to safely update the PR branch with the latest commit in main branch, I want to prevent to reference on the others' commits and show up the actions I made in their issues & PRs. Thanks! |
yes, it looks like a good PR. It's easier to use the Merge button on GitHub to avoid pulling other commits. If you want to re-create, you could start a fresh branch from the current |
Thanks for the suggestion, I'll create another branch. |
Hello, is this issue free to take? Looks like it's already taken by looking at the comments, but nobody is assigned to this one 🤷 |
resolve open-telemetry#11081 Signed-off-by: Hong Chen <[email protected]>
Is your feature request related to a problem? Please describe.
Go stdlib's expvar provides some useful information about Go runtime, and sometimes it is used by various libraries that could be imported by OTEL components to report their own internal state. But the HTTP handler is not exposed by default so there is no way to introspect that state of the libraries in the collector.
Describe the solution you'd like
Since zpage extension is the agreed mechanism for introspection of the running collector, and already provides a webserver, we can register expvar handler on that server (also mentioned in #2155 (comment)).
The zpage extension config can have a flag that enables expvar, which could be off by default.
Describe alternatives you've considered
There could be a separate expvar extension just to create a new webserver and open a port, but it seems like an overkill and not aligned with zpages as the main introspection facility.
The text was updated successfully, but these errors were encountered: