Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver] Move scraper packages into scraper module #11003

Open
mx-psi opened this issue Aug 29, 2024 · 5 comments · May be fixed by #11985
Open

[receiver] Move scraper packages into scraper module #11003

mx-psi opened this issue Aug 29, 2024 · 5 comments · May be fixed by #11985
Assignees
@jackgopack4
Labels
good first issue Good for newcomers
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 29, 2024

We have two packages, scrapererror and scraperhelper that are part of the receiver module, but are not necessary for Collector v1 (we only intend to stabilize the OTLP receiver at first).

We can make a new receiver/scraper module that has these two as packages. This would reduce the API surface that we have to stabilize.
@mx-psi mx-psi added the good first issue Good for newcomers label Aug 29, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Aug 29, 2024

As an example of a PR adding a new module, see #11000.

@zzzk1
Copy link
Contributor

zzzk1 commented Sep 7, 2024

Hi @mx-psi , i would like to try.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 9, 2024

@zzzk1 Please give it a try! :)

@zzzk1 zzzk1 mentioned this issue Sep 13, 2024
Closed
@jackgopack4 jackgopack4 mentioned this issue Nov 4, 2024
Closed
@mx-psi mx-psi unassigned zzzk1 Nov 5, 2024
@jackgopack4 jackgopack4 moved this from Todo to Waiting for reviews in Collector: v1 Nov 5, 2024
@jackgopack4 jackgopack4 mentioned this issue Nov 22, 2024
Merged
bogdandrutu pushed a commit that referenced this issue Dec 2, 2024
@jackgopack4 @mx-psi
[chore] move receiver/scrapererror to scraper/scrapererror (#11733)
32abecb 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Migrates existing scrapererror code to new scraper package. Sets aliases
for receiver/scrapererror so that dependent code in contrib and
elsewhere can be updated
<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to #11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
included unit/integration tests should suffice
<!--Describe the documentation added.-->
#### Documentation
changelog yaml
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
@mx-psi
Copy link
Member Author

mx-psi commented Dec 4, 2024

One of the next steps would be to remove receiver/scraper/scrapererror

This was referenced Dec 4, 2024
Merged
Merged
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Dec 4, 2024
@sincejune
Update scrapererror path (#36680)
386b75e 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove references of `receiver/scrapererror` and replace with
`scraper/scrapererror`

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to
open-telemetry/opentelemetry-collector#11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
None

<!--Please delete paragraphs that you did not use before submitting.-->
bogdandrutu pushed a commit that referenced this issue Dec 4, 2024
@sincejune
Remove receiver/scrapererror (#11800)
d0f5bda 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove receiver/scrapererror alias

<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to #11003 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
Added

<!--Please delete paragraphs that you did not use before submitting.-->
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
@sincejune @shivanthzen
Update scrapererror path (open-telemetry#36680)
6a9e835 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove references of `receiver/scrapererror` and replace with
`scraper/scrapererror`

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to
open-telemetry/opentelemetry-collector#11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
None

<!--Please delete paragraphs that you did not use before submitting.-->
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
@sincejune @ZenoCC-Peng
Update scrapererror path (open-telemetry#36680)
86d3966 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove references of `receiver/scrapererror` and replace with
`scraper/scrapererror`

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to
open-telemetry/opentelemetry-collector#11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
None

<!--Please delete paragraphs that you did not use before submitting.-->
@jackgopack4
Copy link
Contributor

jackgopack4 commented Dec 11, 2024 •
edited
Loading

#11800 removed scrapererror aliases; looks like receiver/scraperhelper is the only remaining package that needs to move to scraper, I understand @bogdandrutu is doing some refactoring work to it before we migrate the package; is this still true?

sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@sincejune @sbylica-splunk
Update scrapererror path (open-telemetry#36680)
c6d28e8 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove references of `receiver/scrapererror` and replace with
`scraper/scrapererror`

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to
open-telemetry/opentelemetry-collector#11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
None

<!--Please delete paragraphs that you did not use before submitting.-->
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@jackgopack4 @mx-psi @HongChenTW
[chore] move receiver/scrapererror to scraper/scrapererror (open-tele…
52d3c96 
…metry#11733)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Migrates existing scrapererror code to new scraper package. Sets aliases
for receiver/scrapererror so that dependent code in contrib and
elsewhere can be updated
<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to open-telemetry#11003

<!--Describe what testing was performed and which tests were added.-->
#### Testing
included unit/integration tests should suffice
<!--Describe the documentation added.-->
#### Documentation
changelog yaml
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@sincejune @HongChenTW
Remove receiver/scrapererror (open-telemetry#11800)
e17fe47 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Remove receiver/scrapererror alias

<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to open-telemetry#11003 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
None

<!--Describe the documentation added.-->
#### Documentation
Added

<!--Please delete paragraphs that you did not use before submitting.-->
@bogdandrutu bogdandrutu linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackgopack4 jackgopack4

Labels
good first issue Good for newcomers
Projects
Collector: v1
Status: In Progress
Milestone
go.opentelemetry.io/receiver 1.0
3 participants
@mx-psi @jackgopack4 @zzzk1