Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 8.0 dependencies for non net9.0, except for System.Diagnostics.DiagnosticSource #6007

Closed
wants to merge 1 commit into from
Closed

Use 8.0 dependencies for non net9.0, except for System.Diagnostics.DiagnosticSource #6007

wants to merge 1 commit into from

Conversation

paulomorgado
Copy link

Fixes #5973

Changes

Do not force Microsoft.Extensions.* to applications not targeting .NET 9.0.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file labels Dec 2, 2024
@paulomorgado paulomorgado changed the title Addresses issue 8973 Use 8.0 dependencies for non net9.0, except for System.Diagnostics.DiagnosticSource Dec 3, 2024
@paulomorgado paulomorgado marked this pull request as ready for review December 3, 2024 08:46
@paulomorgado paulomorgado requested a review from a team as a code owner December 3, 2024 08:46
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Dec 3, 2024
@rajkumar-rangaraj
Copy link
Contributor

SIG Notes: OpenTelemetry 1.10.0 has already been released with the highest version of the Microsoft.Extensions.* package dependencies. At this stage, lowering these package versions would constitute a breaking change. However, we will carefully consider your feedback for upcoming releases to ensure a better alignment with community needs.

@CodeBlanch CodeBlanch closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] targets other than net9.0 shouldn't be forced to use 9.0 dependencies
3 participants
@paulomorgado @rajkumar-rangaraj @CodeBlanch