Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrometheusSpec configuration for Target Allocator #1934

Open
18 tasks
swiatekm opened this issue Jul 18, 2023 · 3 comments
Open
18 tasks

PrometheusSpec configuration for Target Allocator #1934

swiatekm opened this issue Jul 18, 2023 · 3 comments
Labels
area:target-allocator Issues for target-allocator

Comments

@swiatekm
Copy link
Contributor

swiatekm commented Jul 18, 2023

Target Allocator can generate Prometheus configurations based on prometheus-operator Custom Resources, and it does so using code imported from prometheus-operator. In order to generate this configuration, the monitoring CRs like ServiceMonitor aren't sufficient, as some of the configuration lives in the Prometheus CR. The default scrape interval is a good example, see #1925.

We should decide which fields from the Prometheus CR we want to support in the Target Allocator spec. There's quite a few fields in https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#commonprometheusfields, and most of them either don't apply to Target Allocator, or do apply, but are already set in the Collector spec.

The purpose of this issue is to track which fields we should add, and their implementation status.

  • serviceMonitorSelector
  • serviceMonitorNamespaceSelector
  • podMonitorSelector
  • podMonitorNamespaceSelector
  • scrapeTimeout
  • overrideHonorLabels
  • overrideHonorTimestamps
  • ignoreNamespaceSelectors
  • enforcedNamespaceLabel
  • enforcedSampleLimit
  • enforcedTargetLimit
  • enforcedLabelLimit
  • enforcedLabelNameLengthLimit
  • enforcedLabelValueLengthLimit
  • enforcedBodySizeLimit
  • minReadySeconds
  • excludedFromEnforcement
  • podTargetLabels
@swiatekm
Copy link
Contributor Author

An initial list of what seems applicable:

  • serviceMonitorSelector
  • serviceMonitorNamespaceSelector
  • podMonitorSelector
  • podMonitorNamespaceSelector
  • scrapeTimeout
  • overrideHonorLabels
  • overrideHonorTimestamps
  • ignoreNamespaceSelectors
  • enforcedNamespaceLabel
  • enforcedSampleLimit
  • enforcedTargetLimit
  • enforcedLabelLimit
  • enforcedLabelNameLengthLimit
  • enforcedLabelValueLengthLimit
  • enforcedBodySizeLimit
  • minReadySeconds
  • excludedFromEnforcement
  • podTargetLabels

@jaronoff97
Copy link
Contributor

This is something we should do as part of our v2 efforts.

@swiatekm
Copy link
Contributor Author

#3573 adds namespace selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Development

No branches or pull requests

3 participants