Enable BlockForwarding Linter Rules

[arielvalentin]

Ruby 3.1 introduces a more performant anonymous block forwarding syntax that we should adopt once we freeze support for Ruby 3.0

https://bugs.ruby-lang.org/issues/11256

https://docs.rubocop.org/rubocop/cops_naming.html#namingblockforwarding
https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding

[fbogsany]

Reading the issue, it sounds like this is not more performant - just syntactically simpler (no need to provide a block name). The original motivation was mostly about performance, but lazy proc allocation for blocks invalidated the performance rationale.

Not saying “no, don’t do this” - just pointing out there’s no performance benefit to doing so.

[github-actions]

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.