Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a Gauge<u64>? #2391

Open
utpilla opened this issue Dec 6, 2024 · 1 comment
Open

Do we need a Gauge<u64>? #2391

utpilla opened this issue Dec 6, 2024 · 1 comment
Assignees
Milestone

Comments

@utpilla
Copy link
Contributor

utpilla commented Dec 6, 2024

OTLP proto only allows for f64 and i64 values. We already have Gauge<f64> and Gauge<i64>.

Gauge<u64> doesn't add any additional value.

Counters and Histograms could have also used only f64 and i64 variants. However, the spec states that Counter and Histogram measurements should not be negative. So, using an u64 variant, helps enforcing that.

@cijothomas cijothomas added this to the 0.28.0 milestone Dec 9, 2024
@cijothomas
Copy link
Member

Gauge<u64> maybe removed. I understand we are already at a RC state, but this is better to be done before 1.0 after which it is not possible to remove at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants