Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear where UserInteractionInstrumentation and XMLHttpRequestInstrumentation should be imported from. #4951

Open
gilisho opened this issue Aug 5, 2024 · 6 comments · May be fixed by #5710

Comments

@gilisho
Copy link

gilisho commented Aug 5, 2024

Suggested improvements for page: https://opentelemetry.io/docs/languages/js/getting-started/browser/#add-instrumentations

As a starting point in OpenTelemetry, it is unclear where UserInteractionInstrumentation and XMLHttpRequestInstrumentation should be imported from.

@svrnm svrnm changed the title Page feedback unclear where UserInteractionInstrumentation and XMLHttpRequestInstrumentation should be imported from. Aug 5, 2024
@svrnm
Copy link
Member

svrnm commented Aug 5, 2024

thank you for your feedback @gilisho!

@open-telemetry/javascript-approvers please take a look

@svrnm svrnm moved this to Need SIG Review in SIG Comms: PRs & Issues Aug 5, 2024
@JamieDanielson
Copy link
Member

@gilisho thanks for pointing this out! Would you be interested in creating a PR with these changes? Something like this is probably what should get added into there.

npm install @opentelemetry/instrumentation-user-interaction \
  @opentelemetry/instrumentation-xml-http-request \
import { UserInteractionInstrumentation } from '@opentelemetry/instrumentation-user-interaction';
import { XMLHttpRequestInstrumentation } from '@opentelemetry/instrumentation-xml-http-request';

// code from earlier step

// Registering instrumentations
registerInstrumentations({
  instrumentations: [
    new DocumentLoadInstrumentation(), // from earlier
    new UserInteractionInstrumentation(),
    new XMLHttpRequestInstrumentation(),
  ],
});

@gilisho
Copy link
Author

gilisho commented Aug 20, 2024

Hey, sorry for the late reply. I'd love to contribute. will push a PR in the following days! 😄

@svrnm
Copy link
Member

svrnm commented Nov 26, 2024

@gilisho are you still interested in helping?

@gilisho
Copy link
Author

gilisho commented Dec 1, 2024

Hi, I've submitted the PR now. Thanks!

@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

Hi, I've submitted the PR now. Thanks!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Need SIG Review
Development

Successfully merging a pull request may close this issue.

3 participants