-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unclear where UserInteractionInstrumentation and XMLHttpRequestInstrumentation should be imported from. #4951
Comments
thank you for your feedback @gilisho! @open-telemetry/javascript-approvers please take a look |
@gilisho thanks for pointing this out! Would you be interested in creating a PR with these changes? Something like this is probably what should get added into there. npm install @opentelemetry/instrumentation-user-interaction \
@opentelemetry/instrumentation-xml-http-request \ import { UserInteractionInstrumentation } from '@opentelemetry/instrumentation-user-interaction';
import { XMLHttpRequestInstrumentation } from '@opentelemetry/instrumentation-xml-http-request';
// code from earlier step
// Registering instrumentations
registerInstrumentations({
instrumentations: [
new DocumentLoadInstrumentation(), // from earlier
new UserInteractionInstrumentation(),
new XMLHttpRequestInstrumentation(),
],
}); |
Hey, sorry for the late reply. I'd love to contribute. will push a PR in the following days! 😄 |
@gilisho are you still interested in helping? |
Hi, I've submitted the PR now. Thanks! |
Thanks! |
Suggested improvements for page: https://opentelemetry.io/docs/languages/js/getting-started/browser/#add-instrumentations
As a starting point in OpenTelemetry, it is unclear where
UserInteractionInstrumentation
andXMLHttpRequestInstrumentation
should be imported from.The text was updated successfully, but these errors were encountered: