Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

CORS Max-Age is not set resulting in 2 requests for each command on Firefox #8542

Closed
ethernomad opened this issue May 4, 2018 · 3 comments · May be fixed by #11819
Closed

CORS Max-Age is not set resulting in 2 requests for each command on Firefox #8542

ethernomad opened this issue May 4, 2018 · 3 comments · May be fixed by #11819
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone
2.6

Comments

@ethernomad
Copy link
Contributor

Parity/v1.9.7-stable-7919629-20180423/x86_64-linux-gnu/rustc1.25.0
connected to MIX Blockchain

Currently every RPC command is 2 requests from Firefox. First the OPTIONS pre-flight and then the actual request. By setting CORS Max-Age to 10 minutes the number of requests can be cut in half. For high latency connections to the node, this has significant performance improvements.

Geth had the exact same problem: ethereum/go-ethereum#3079
screenshot from 2018-05-04 14-33-09
@Tbaut
Copy link
Contributor

Tbaut commented May 4, 2018

Thanks! PR always welcome :)

@Tbaut Tbaut added F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. P5-sometimesoon 🌲 Issue is worth doing soon. M6-rpcapi 📣 RPC API. labels May 4, 2018
@Tbaut Tbaut added this to the 1.12 milestone May 4, 2018
@tomusdrw
Copy link
Collaborator

tomusdrw commented May 4, 2018

Neat! Requires implementation in https://github.com/paritytech/jsonrpc

This was referenced May 4, 2018
Closed
Closed
@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 17, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
@debris
Copy link
Collaborator

debris commented Jul 7, 2019

implemented a long time ago in paritytech/jsonrpc#280

@debris debris closed this as completed Jul 7, 2019
@tbcd tbcd mentioned this issue Jul 14, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
2.6
Development

Successfully merging a pull request may close this issue.

Add CORS Max-Age header of 600 seconds tbcd/openethereum
6 participants
@ethernomad @tomusdrw @debris @5chdn @Tbaut @soc1c