@ExtendWith(SpringExtension.class) is added twice when class contains @SpringClassRule

[FieteO]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v5.22.0

How are you running OpenRewrite?

I am using the command line invocation:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot2.SpringBoot2JUnit4to5Migration -Drewrite.exportDatatables=true

What is the smallest, simplest way to reproduce the problem?

import org.junit.ClassRule;
import org.junit.Rule;
import org.springframework.test.context.junit4.rules.SpringClassRule;
import org.springframework.test.context.junit4.rules.SpringMethodRule;

public class MyTest {

        @ClassRule
        public static final SpringClassRule springClassRule = new SpringClassRule();

        @Rule
        public final SpringMethodRule springMethodRule = new SpringMethodRule();

}

What did you expect to see?

import org.junit.jupiter.api.extension.ExtendWith;
import org.springframework.test.context.junit.jupiter.SpringExtension;

@ExtendWith(SpringExtension.class)
public class MyTest {

}

What did you see instead?

The @ExtendWith() annotation is added twice and the org.springframework.test.context.junit.jupiter.SpringExtension import is missing.

import org.junit.jupiter.api.extension.ExtendWith;

@ExtendWith(SpringExtension.class)
@ExtendWith(SpringExtension.class)
public class MyTest {

}

Are you interested in contributing a fix to OpenRewrite?

No

[timtebeek]

Hi @FieteO ; We have a test cas e that's nearly identical to what you have reported that passes:

rewrite-spring/src/test/java/org/openrewrite/java/spring/test/SpringRulesToJUnitExtensionTest.java

Lines 104 to 136 in 729164f

	@Test
	void migrateAndAddSpringExtension() {
	rewriteRun(
	//language=java
	java(
	"""
	import org.springframework.test.context.junit4.rules.SpringClassRule;
	import org.springframework.test.context.junit4.rules.SpringMethodRule;
	import org.junit.ClassRule;
	import org.junit.Rule;
	class SomeTest {
	@ClassRule
	public static final SpringClassRule springClassRule = new SpringClassRule();
	@Rule
	public final SpringMethodRule springMethodRule = new SpringMethodRule();
	}
	""",
	"""
	import org.junit.jupiter.api.extension.ExtendWith;
	import org.springframework.test.context.junit.jupiter.SpringExtension;
	@ExtendWith(SpringExtension.class)
	class SomeTest {
	}
	"""
	)
	);
	}

Would you mind altering that test to match your case and make it fail? Because right now this can not be replicated.