Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Request] Add OpenSearch Endpoint as a GitHub Secret for OpenSearch Dashboards #247

Open
sejli opened this issue Dec 12, 2024 · 4 comments
Assignees

Comments

@sejli
Copy link
Member

sejli commented Dec 12, 2024

What is the type of request?

Secret Update

Details of the request

OpenSearch Dashboards currently has no integration testing for S3 datasets in Discover 2.0. Because of the technicalities and challenges behind setting up an OpenSearch environment with S3 support on a GitHub runner, we plan on temporarily adding a working endpoint with S3 support as a secret, and use that as a single backend for Cypress integration tests per PR.

Additional information to support your request

This should be a temporary workaround to get integration testing for this feature, and will be worked on in collaboration between the opensearch-sql maintainers and OpenSearch-Dashboards to get a locally built OpenSearch with S3 support within GitHub Runners.

Not sure where to include this endpoint and the necessary username and password.

When does this request need to be completed?

As soon as possible. There are ongoing changes for this feature, and we want to catch regressions as new PRs come in without needing to manually sign off each time.

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

@peterzhuamazon
Copy link
Member

Hi @sejli ,

Will ft repo have this change as well?
Or is this something only for OSD core repo?

Another question would be even if you get it run on GitHub Actions, how can you replicate the same on Jenkins during release phase?

Thanks,
Peter

@sejli
Copy link
Member Author

sejli commented Dec 12, 2024

Hey @peterzhuamazon, thanks for the response. Currently, we plan on just using it as a PR workflow in the OSD core repo and monitoring the usage until we have more bandwidth for the long term solution. For the second question, are all Cypress tests from OSD core repo run on Jenkins during release phase?

@peterzhuamazon
Copy link
Member

Hey @peterzhuamazon, thanks for the response. Currently, we plan on just using it as a PR workflow in the OSD core repo and monitoring the usage until we have more bandwidth for the long term solution. For the second question, are all Cypress tests from OSD core repo run on Jenkins during release phase?

  1. When do you plan on deprecating this temporary solution?
  2. We are only running tests from ft repo on Jenkins for now.

@sejli
Copy link
Member Author

sejli commented Dec 13, 2024

Currently, we are still looking to allocate resources between the opensearch-sql and opensearch-spark maintainers to work with OpenSearch-Dashboards maintainers on the long term goal, so there hasn't been an end goal set yet. However, we will be monitoring the usage and updating if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants